-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TreeView] Return instance
and publicAPI
methods from plugin and populate the main objects inside useTreeView
#12650
Merged
flaviendelangle
merged 6 commits into
mui:master
from
flaviendelangle:remove-populate-methods
Apr 8, 2024
Merged
[TreeView] Return instance
and publicAPI
methods from plugin and populate the main objects inside useTreeView
#12650
flaviendelangle
merged 6 commits into
mui:master
from
flaviendelangle:remove-populate-methods
Apr 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late the main objects inside useTreeView
Deploy preview: https://deploy-preview-12650--material-ui-x.netlify.app/ Updated pages: |
flaviendelangle
added
the
component: tree view
TreeView, TreeItem. This is the name of the generic UI component, not the React module!
label
Apr 3, 2024
flaviendelangle
force-pushed
the
remove-populate-methods
branch
from
April 3, 2024 12:43
3c9ba67
to
ba7e755
Compare
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Apr 3, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Apr 3, 2024
noraleonte
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very interesting change 👏 It makes total sense!
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
…populate the main objects inside `useTreeView` (mui#12650)
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
…populate the main objects inside `useTreeView` (mui#12650)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: tree view
TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for a DX change on the plugin API.
Right now, we are populating the
instance
andpublicAPI
objects inside each plugin using thepopulateInstance
andpopulatePublicAPI
methods.This PR proposes to instead have the plugin returning them and
useTreeView
do the population.Advantages
contextValue
which is returned by each plugininstance
orpublicAPI
instance
no longer need to access this parameterpublicAPI
parameter can be totally removed from the plugin parameters