[DataGrid] Improve fastObjectShallowCompare
#12022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romgrk
added
performance
component: data grid
romgrk
requested review from
MBilalShafi and
cherniavskii
and removed request for
MBilalShafi and
cherniavskii
|
Actually this one is incorrect: |
|
Deploy preview: https://deploy-preview-12022--material-ui-x.netlify.app/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The guard removed here is not necessary due to the final
aLength === bLengthcheck. This optimization is done under the assumption that the objects are likely to be equal, so short-circuiting there is unlikely to happen.