Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] cherry pick of #11805 #11993

Closed

Conversation

michelengelen
Copy link
Member


cherry picking of #11805

@michelengelen michelengelen self-assigned this Feb 8, 2024
@michelengelen michelengelen changed the base branch from next to master February 8, 2024 13:12
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, just asking: do we need it? 🤔
Shouldn't the actions on default branch be run? 🤷

@michelengelen
Copy link
Member Author

I'm not sure, just asking: do we need it? 🤔 Shouldn't the actions on default branch be run? 🤷

Good question ... I was just wondering why it did not run yet on any closed issue. Thought that might be because it is not on master

@mui-bot
Copy link

mui-bot commented Feb 8, 2024

Deploy preview: https://deploy-preview-11993--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against a3f3d64

@LukasTy
Copy link
Member

LukasTy commented Feb 8, 2024

Good question ... I was just wondering why it did not run yet on any closed issue. Thought that might be because it is not on master

Yeah, makes sense, I also checked and did not see any failed actions... 🤷

@michelengelen
Copy link
Member Author

It seems that it is working as expected:

Screenshot 2024-02-08 at 14 16 41

Going to close this PR then! Sry for the confusion @joserodolfofreitas and @LukasTy ! 🙇🏼

@michelengelen michelengelen added the scope: docs-infra Specific to the docs-infra product label Feb 8, 2024
@michelengelen michelengelen deleted the picks/close-message-automation branch February 8, 2024 13:52
@MBilalShafi
Copy link
Member

Yes, it picks from the default branch, I also wondered on this a bit with the previous workflow. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants