Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tree view][docs] Adjust all demos height to account for the updated design #11979

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

danilo-leal
Copy link
Contributor

Closes #11976

Follow-up on the design update done on #11529 😃 I haven't added any overflow and rather just added fixed height for demos with a short amount of items and a min-height for those that have a bigger list.

@danilo-leal danilo-leal added docs Improvements or additions to the documentation component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Feb 7, 2024
@danilo-leal danilo-leal self-assigned this Feb 7, 2024
@danilo-leal danilo-leal changed the title [docs][Tree View] Adjust all demos height to account for the updated design [Tree View][docs] Adjust all demos height to account for the updated design Feb 7, 2024
@mui-bot
Copy link

mui-bot commented Feb 7, 2024

Deploy preview: https://deploy-preview-11979--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 48e56cc

@oliviertassinari oliviertassinari changed the title [Tree View][docs] Adjust all demos height to account for the updated design [tree view][docs] Adjust all demos height to account for the updated design Feb 7, 2024
@danilo-leal
Copy link
Contributor Author

Uhm... the test_types check is picking up components I didn't even touch on this PR. 🤔 Any ideas why?

@flaviendelangle
Copy link
Member

No idea, you can try to merge with next

Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@danilo-leal danilo-leal merged commit d28d48a into mui:next Feb 15, 2024
17 checks passed
@danilo-leal danilo-leal deleted the adjust-treeview-demos-height branch February 15, 2024 18:01
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tree view] Fix demo overflow
5 participants