-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tree view][docs] Adjust all demos height to account for the updated design #11979
Merged
danilo-leal
merged 4 commits into
mui:next
from
danilo-leal:adjust-treeview-demos-height
Feb 15, 2024
Merged
[tree view][docs] Adjust all demos height to account for the updated design #11979
danilo-leal
merged 4 commits into
mui:next
from
danilo-leal:adjust-treeview-demos-height
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
docs
Improvements or additions to the documentation
component: tree view
TreeView, TreeItem. This is the name of the generic UI component, not the React module!
labels
Feb 7, 2024
danilo-leal
changed the title
[docs][Tree View] Adjust all demos height to account for the updated design
[Tree View][docs] Adjust all demos height to account for the updated design
Feb 7, 2024
1 task
Deploy preview: https://deploy-preview-11979--material-ui-x.netlify.app/ |
oliviertassinari
changed the title
[Tree View][docs] Adjust all demos height to account for the updated design
[tree view][docs] Adjust all demos height to account for the updated design
Feb 7, 2024
Uhm... the test_types check is picking up components I didn't even touch on this PR. 🤔 Any ideas why? |
No idea, you can try to merge with |
noraleonte
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
…design (mui#11979) Co-authored-by: alexandre <[email protected]> Co-authored-by: noraleonte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: tree view
TreeView, TreeItem. This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11976
Follow-up on the design update done on #11529 😃 I haven't added any
overflow
and rather just added fixed height for demos with a short amount of items and a min-height for those that have a bigger list.