Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid][FilterPanel] Fix styling grid filter input single select #11520

Merged
merged 11 commits into from
Feb 15, 2024
Merged

[DataGrid][FilterPanel] Fix styling grid filter input single select #11520

merged 11 commits into from
Feb 15, 2024

Conversation

FreakDroid
Copy link
Contributor

This PR fixes 8703

Wilfredo Perez added 2 commits December 26, 2023 12:13
Fixing: mui#8703
42ee0c4 
-GridFilterInputSingleSelect is not correctly applied for outlined variant
Fixing: mui#8703
be2a472 
-GridFilterInputSingleSelect is not correctly applied for outlined variant
@mui-bot
Copy link

mui-bot commented Dec 26, 2023 •
edited
Loading

Deploy preview: https://deploy-preview-11520--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against a0dacb2

Wilfredo Perez added 3 commits December 26, 2023 14:36
Fixing: mui#8703
687eaf3 
-GridFilterInputSingleSelect is not correctly applied for outlined variant
Merge remote-tracking branch 'origin/fix-styling-gridFilterInputSingl…
483e5c4 
…eSelect' into fix-styling-gridFilterInputSingleSelect
Fixing: mui#8703
0cdfe8c
@FreakDroid FreakDroid marked this pull request as ready for review December 26, 2023 15:34
@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Dec 26, 2023
@zannager zannager requested a review from romgrk January 12, 2024 11:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 5, 2024
Merge branch 'next-mui-main' into fix-styling-gridFilterInputSingleSe…
554e7b0 
…lect

# Conflicts:
#	packages/x-data-grid/src/components/panel/filterPanel/GridFilterInputSingleSelect.tsx
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 15, 2024
@FreakDroid
Copy link
Contributor Author

Hey @romgrk can you check this PR, please? My team is waiting for this change for several months. We have the pro version.

Thanks in advance.

romgrk
romgrk reviewed Feb 15, 2024
View reviewed changes
packages/x-data-grid/src/components/panel/filterPanel/GridFilterInputBoolean.tsx
Comment on lines +85 to +86
variant={variant}
notched={variant === 'outlined' ? true : undefined}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mui/xgrid Now that I look at this, I realized that the outlined variant of MUI TextField is actually a better choice for UX, because it looks much more like a text input than the standard variant. What do we think about using the outlined variant by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't if this comment is for me. Basically, I think that it is better to have standard by default because all the examples are using this variant.

romgrk
romgrk approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@romgrk romgrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint the commented import and LGTM.

@romgrk
Copy link
Contributor

romgrk commented Feb 15, 2024

@FreakDroid Do you need this on the v6 branch?

@FreakDroid
Copy link
Contributor Author

@FreakDroid Do you need this on the v6 branch?

If this is the release coming would be great. In our app, we are trying to close this issue ASAP.

@romgrk romgrk added the needs cherry-pick The PR should be cherry-picked to master after merge label Feb 15, 2024
@romgrk romgrk merged commit 5cf9f36 into mui:next Feb 15, 2024
18 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 15, 2024
@FreakDroid @web-flow
[DataGrid][FilterPanel] Fix styling grid filter input single select (#…
d297703 
…11520)

Co-authored-by: Wilfredo Perez <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
Merged
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@FreakDroid @thomasmoon
[DataGrid][FilterPanel] Fix styling grid filter input single select (m…
29de259 
…ui#11520)

Co-authored-by: Wilfredo Perez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romgrk romgrk Awaiting requested review from romgrk

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Styling of GridFilterInputSingleSelect is not correctly applied
4 participants
@FreakDroid @mui-bot @romgrk @zannager