Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix cherry-pick action #11446

Merged
merged 3 commits into from
Dec 18, 2023
Merged

[core] Fix cherry-pick action #11446

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b74d71f
[core] Fix `cherry-pick` action
LukasTy Dec 18, 2023
d32bf77
Update .github/workflows/cherry-pick-next-to-master.yml
LukasTy Dec 18, 2023
8b4266c
prettier
MBilalShafi Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cherry-pick-next-to-master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
on:
pull_request:
pull_request_target:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/marketplace/actions/github-cherry-pick-action#working-with-forked-repositories
And also

mui-x/.github/workflows/maintenance.yml

Line 12 in cec51c5

pull_request_target:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I totally missed this part 😞

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, all of us as well, because we approved your original PR. 🙈 🤷

Copy link
Member

@MBilalShafi MBilalShafi Dec 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed, it worked with the new config and these settings:
image

Removing checkmark from Allow Github actions to create... makes it fail.

branches:
- next
types: ['closed']
Expand All @@ -21,8 +21,8 @@ jobs:
uses: carloscastrojumo/[email protected]
with:
branch: master
token: ${{ secrets.GITHUB_TOKEN }}
MBilalShafi marked this conversation as resolved.
Show resolved Hide resolved
body: 'Cherry-pick of #{old_pull_request_id}'
cherry-pick-branch: ${{ format('cherry-pick-{0}', github.event.number) }}
labels: |
cherry-pick
env:
Expand Down