[infra] Create first reusable workflow #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed on a team slug
…used and not as a standalone action
michelengelen
added
the
scope: infra
JCQuintas
reviewed
May 6, 2024
Co-authored-by: Jose C Quintas Jr <[email protected]> Signed-off-by: Michel Engelen <[email protected]>
|
FYI: the other changes are also present in #158 because i branched off of it! 👍🏼 |
|
@prakhargupta1 do you have an idea why the Cirlce CI steps are not running? |
JCQuintas
approved these changes
May 6, 2024
Closed
Nope, it did run in the Circle CI dashboard though. Your old PRs also seem to have the same concern. |
| DATA=$(gh api \ | ||
| -H "Accept: application/vnd.github+json" \ | ||
| -H "X-GitHub-Api-Version: 2022-11-28" \ | ||
| /orgs/${{ github.repository_owner }}/teams/${{ inputs.team-slug }}/members?role=maintainer&per_page=100 \ |
There was a problem hiding this comment.
I don't understand this logic. Is this PR meant to experiment with reusable workflow?
@michelengelen #162 (comment). It should work now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the first reusable workflow: add PR reviewers based on team