Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[example] Update the CDN example to adapt React 19. #44979

Merged
merged 4 commits into from
Jan 11, 2025

Conversation

IceOfSummer
Copy link
Contributor

@IceOfSummer IceOfSummer commented Jan 9, 2025

Original example is not available on React 19:

Uncaught SyntaxError: The requested module 'react-dom' does not provide an export named 'createRoot'

Live preview:

Signed-off-by: IceOfSummer <[email protected]>
Signed-off-by: IceOfSummer <[email protected]>
Signed-off-by: IceOfSummer <[email protected]>
@mui-bot
Copy link

mui-bot commented Jan 9, 2025

Netlify deploy preview

https://deploy-preview-44979--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 309b7f6

@zannager zannager added the examples Relating to /examples label Jan 10, 2025
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@ZeeshanTamboli ZeeshanTamboli merged commit 02dba2b into mui:master Jan 11, 2025
19 checks passed
@IceOfSummer IceOfSummer deleted the support-react19-in-cdn branch January 11, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Relating to /examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants