-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Remove Suspense and clock mocking from regressions and e2e tests #44935
Conversation
Netlify deploy previewhttps://deploy-preview-44935--material-ui.netlify.app/ Bundle size report |
The latest run indicates this is related to changes in Suspense. When removing the Suspense barrier, the regression test goes back to ~4m runtime. |
About the broken Argos test:
On another note: Should we also remove Suspense from the e2e TestViewer? material-ui/test/e2e/TestViewer.js Line 16 in 4fd86d9
This test doesn't present such a difference (React 18 28s and React 19 36s in #44868), but it might be due to it only having 11 tests. |
Answer: We're mocking the clock: material-ui/test/regressions/TestViewer.js Lines 35 to 38 in 4fd86d9
|
Confirmed that the e2e tests also shows the 300s throttling, removing |
Ok, ready for review @Janpot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me, we could live with the yearly flakey test. Alternatively, the following may work in the screenshot call to mask the copyright text:
mask: page.getByText(/Copyright © Sitemark \d\d\d\d\./)
Closes: #44920
Changes:
TestViewer
component in regressions and e2e tests. They're not required and add a 300ms throttle in React 19 ([React 19] Suspense throttling behavior (FALLBACK_THROTTLE_MS
) kicks in too often facebook/react#31819)