[system] Fix dark mode flicker using useEnhancedEffect
#44812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
customization: theme
siriwatknp
changed the title
useEnhancedEffectuseEnhancedEffect
Netlify deploy previewhttps://deploy-preview-44812--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
siriwatknp
force-pushed
the
fix/flicker-client-side
branch
from
19316e2 to
93d5653
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug on client-side apps only.
For server-side apps, the
modeis correctly set before the app render byInitColorSchemeScriptcomponent.Root cause
The logic of updating the html's class attribute lives within
useEffectinstead ofuseLayoutEffect.Even though, the first render has mode
darkbased onnoSsrprop, theclass="dark"applied to<html>happens after Browser has painted the first render.The fix is to use
useEnhancedEffect(a wrapper ofuseLayoutEffectfor client-side) to attachclass="dark"before browser paint.Before:
The right button renders with default blue before turning red.
Screen.Recording.2567-12-19.at.17.03.21.mov
After:
Screen.Recording.2567-12-19.at.17.02.24.mov