[material-ui] Add warning when using noSsr incorrectly
#44624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
package: material-ui
Netlify deploy previewhttps://deploy-preview-44624--material-ui.netlify.app/ Bundle size report |
aarongarciah
changed the title
noSsr incorrectlynoSsr incorrectly
DiegoAndai
reviewed
Dec 3, 2024
| console.error( | ||
| [ | ||
| 'MUI: The `noSsr` prop must be used with the theme that contains light and dark colorSchemes.', | ||
| 'See https://mui.com/material-ui/customization/dark-mode/#built-in-support for more details.', |
There was a problem hiding this comment.
Same feedback as in #43783 (comment).
| export default function ThemeProviderNoVars<Theme = DefaultTheme>({ | ||
| theme: themeInput, | ||
| ...props | ||
| }: ThemeProviderNoVarsProps<Theme>): React.ReactElement<ThemeProviderNoVarsProps<Theme>> { | ||
| const scopedTheme = THEME_ID in themeInput ? themeInput[THEME_ID] : undefined; | ||
| if (process.env.NODE_ENV !== 'production') { | ||
| // @ts-ignore | ||
| if (process.env.NODE_ENV !== 'test' && props.noSsr && !warnedOnceNoSsr) { |
There was a problem hiding this comment.
The test env check seems suspicious. Do we have leaks in our own tests?
Suggested change
| if (process.env.NODE_ENV !== 'test' && props.noSsr && !warnedOnceNoSsr) { | |
| if (props.noSsr && !warnedOnceNoSsr) { |
| export default function ThemeProviderNoVars<Theme = DefaultTheme>({ | ||
| theme: themeInput, | ||
| ...props | ||
| }: ThemeProviderNoVarsProps<Theme>): React.ReactElement<ThemeProviderNoVarsProps<Theme>> { | ||
| const scopedTheme = THEME_ID in themeInput ? themeInput[THEME_ID] : undefined; | ||
| if (process.env.NODE_ENV !== 'production') { |
There was a problem hiding this comment.
Would it make sense to run this test inside ThemeProvider.tsx rather than in this file? It seems that it could be easier to refactor down the line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #44576