[code-infra] Changes for test util to work in vitest
#43625
Conversation
Netlify deploy previewhttps://deploy-preview-43625--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
This reverts commit 76edd75.
oliviertassinari
changed the title
vitestvitest
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
added
PR: out-of-date
| @@ -28,13 +28,15 @@ import { EventHandlers } from '../utils/types'; | |||
| const EMPTY_OBJECT = {}; | |||
| const NOOP = () => {}; | |||
|
|
|||
| const defaultItemComparer = <ItemValue>(optionA: ItemValue, optionB: ItemValue) => | |||
| optionA === optionB; | |||
| function defaultItemComparer<ItemValue>(optionA: ItemValue, optionB: ItemValue) { | |||
There was a problem hiding this comment.
Is this related to vitest changes?
There was a problem hiding this comment.
Yes, vitest can't execute jsx in js files. There's a workaround, but you have to have every file interpreted as jsx. That unfortunately breaks this code.
| @@ -932,7 +932,7 @@ describe('Joy <Autocomplete />', () => { | |||
| it('should ignore keydown event until the IME is confirmed', function test() { | |||
| // TODO: Often times out in Firefox 78. | |||
| // Is this slow because of testing-library or because of the implementation? | |||
| this.timeout(4000); | |||
| this?.timeout?.(4000); | |||
There was a problem hiding this comment.
Is vitest fast enough that we don't need an increased timeout?
There was a problem hiding this comment.
Haven't seen it timeout yet. Will add it back for vitest if it's a problem. Otherwise we'll remove this altogether
| @@ -0,0 +1,9 @@ | |||
| // Shim for vitest describe.skipIf to be able to run mocha and vitest side-by-side | |||
| // TODO: Remove after migration to vitest is complete | |||
| const describeSkipIf: (condition: boolean) => Mocha.PendingSuiteFunction = | |||
There was a problem hiding this comment.
I hope it's just temporary, as the name is terrible :)
There was a problem hiding this comment.
Yes, we'll turn this into describe.skipIf once we're away from mocha. There is no way to monkey patch in mocha, they don't expose these in the setup files
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
Related to mui/mui-x#14508
Help toward mui/mui-public#170