[material-ui] Fix createTheme with just color schemes
#43518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…create-theme-colorschemes
siriwatknp
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-43518--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
DiegoAndai
reviewed
Aug 29, 2024
| theme.defaultColorScheme = defaultColorSchemeInput; | ||
| theme.colorSchemes = colorSchemesInput as Record<string, ColorSystem>; | ||
|
|
||
| if (theme.palette.mode === 'light') { | ||
| theme.colorSchemes.light = { palette: theme.palette } as ColorSystem; | ||
| theme.colorSchemes.light = { | ||
| ...(colorSchemesInput.light !== true && colorSchemesInput.light), |
There was a problem hiding this comment.
Isn't this covered by line 100 above?
There was a problem hiding this comment.
Without this line, the other fields that are not palette will be overridden because of the reassigning theme.colorSchemes.light.
Co-authored-by: Diego Andai <[email protected]> Signed-off-by: Siriwat K <[email protected]>
DiegoAndai
approved these changes
Aug 30, 2024
|
@siriwatknp Thank you for addressing the issue. Could you please let me know when we can expect the patch version to be released with this fix? |
|
@ksn5 this should be available in the next patch version, |
This was referenced Sep 25, 2024
This was referenced Oct 3, 2024
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #43508, closes #43533