[docs-infra] Fix visual look of in-house ad #42735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
oliviertassinari
force-pushed
the
fix-ad-in-house
branch
from
530257d
to
4717992
Compare
| <Typography variant="body2" component="span" gutterBottom sx={{ display: 'block' }}> | ||
| <Typography variant="body2" component="span" sx={{ display: 'block' }}> |
There was a problem hiding this comment.
A side win, avoid a layout shift when <PleaseDisableAdblock /> triggers. It's a bit too tall, removing the margin makes it fit within AD_HEIGHT.
This was referenced Jun 23, 2024
Netlify deploy previewhttps://deploy-preview-42735--material-ui.netlify.app/ Bundle size report |
|
@danilo-leal Can you verify from a design perspective? |
|
Oh actually, I saw another regression while I was checking the other links. Fixing this in: #42743. |
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression introduced in #39603 and #42498.
#39603 introduced the broken anchor blue color
#42498 introduced the broken style rendering logic
Before
After
Preview https://deploy-preview-42735--material-ui.netlify.app/material-ui/getting-started/