Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Fix wrong migration #42675

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jun 18, 2024

A regression from #42498

I think this case was my manual adjustment mistake. I missed the theme.breakpoints.up. The codemod improvement will come in a separate PR.

Before After
Screenshot 2024-06-18 at 08 43 48 Screenshot 2024-06-18 at 08 43 41

@siriwatknp siriwatknp added docs Improvements or additions to the documentation regression A bug, but worse labels Jun 18, 2024
@mui-bot
Copy link

mui-bot commented Jun 18, 2024

Netlify deploy preview

https://deploy-preview-42675--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 209c6b5

@mnajdova
Copy link
Member

Can you do screenshots of what you are trying to fix? It would help with the review.

@danilo-leal danilo-leal changed the title [docs] Fix wrong migration [docs-infra] Fix wrong migration Jun 18, 2024
@danilo-leal danilo-leal added scope: docs-infra Specific to the docs-infra product and removed docs Improvements or additions to the documentation labels Jun 18, 2024
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Jun! Added the screenshots in the description 👍

@siriwatknp siriwatknp merged commit c96d05e into mui:next Jun 19, 2024
21 checks passed
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression A bug, but worse scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants