Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[utils] Convert all exports to modules #39882

Merged
merged 9 commits into from
Jan 26, 2024
Merged

[utils] Convert all exports to modules #39882

merged 9 commits into from
Jan 26, 2024

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Nov 15, 2023 •
edited
Loading

Related to #35840. All exports must be modules to be able to have nested imports. Similar to #37586

@mnajdova mnajdova added package: utils Specific to the @mui/utils package core Infrastructure work going on behind the scenes labels Nov 15, 2023
@mnajdova mnajdova mentioned this pull request Nov 15, 2023
Closed
1 task
@mui-bot
Copy link

mui-bot commented Nov 15, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-39882--material-ui.netlify.app/

@material-ui/lab: parsed: -0.41% 😍, gzip: -0.33% 😍
@mui/material-next: parsed: -0.26% 😍, gzip: -0.29% 😍

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 97dbb7c

@mnajdova mnajdova marked this pull request as ready for review November 15, 2023 11:14
@mnajdova mnajdova requested a review from a team November 15, 2023 11:14
@mj12albert
Copy link
Member

I've tried re-running the whole CI but yarn size:snapshot is still failing 🤔

@mnajdova mnajdova requested review from michaldudak and removed request for michaldudak November 30, 2023 09:54
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 21, 2023
@siriwatknp
Copy link
Member

This would fix #40434 (comment)

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 15, 2024
siriwatknp
siriwatknp approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 25, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 26, 2024
@siriwatknp siriwatknp enabled auto-merge (squash) January 26, 2024 02:28
@siriwatknp siriwatknp merged commit c361a6e into mui:master Jan 26, 2024
18 checks passed
oliviertassinari
oliviertassinari reviewed Jan 29, 2024
View reviewed changes
packages/mui-utils/package.json
Comment on lines -32 to +33
"build:node": "node ../../scripts/build.mjs node",
"build:stable": "node ../../scripts/build.mjs stable",
"build:node": "node ../../scripts/build.mjs node --ignoreTopLevel",
"build:stable": "node ../../scripts/build.mjs stable --ignoreTopLevel",
Copy link
Member

@oliviertassinari oliviertassinari Jan 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not default to using the same bundling approach as in @mui/material? I thought @mui/icons-material was the exception we had, an approach that performs worth in terms of bundle compatibility but leads to a smaller package size.

    "build:node": "node ../../scripts/build.mjs node",
    "build:stable": "node ../../scripts/build.mjs stable",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, looking at it again I think I misunderstood. Will create another PR to fix it.

@oliviertassinari
Copy link
Member

Great to see this change done 👍

@siriwatknp siriwatknp mentioned this pull request Jan 29, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes package: utils Specific to the @mui/utils package performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mnajdova @mui-bot @mj12albert @siriwatknp @oliviertassinari