-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Card] Fix CardActions
spacing for different button components
#31885
base: master
Are you sure you want to change the base?
Conversation
Netlify deploy previewhttps://deploy-preview-31885--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
CardActions
spacing for different button components
Just noticed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using gap
is perfect but due to browser support being at 88% (at least, I think it should be 90%), I don't think it is safe to use gap
at this point. I propose to not do anything at this point because I don't see a better approach at this point because using margin always stuck in some cases and developers can use sx
to add the margin on their own.
'& > * + *': {
marginLeft: 8, // only works in row, but not the column direction
},
@siriwatknp Understood, I added this PR on the list of #30660 |
We can merge this in v7. |
Signed-off-by: Jan Potoms <[email protected]>
@siriwatknp I've merged master and replaced the tests with integration tests. The tests were testing implementation details and that's rather useless in this case (i.e. the computed styles don't necessarily guarantee the gap is correct visually, other properties may affect it). |
I think it's fine to not have extra tests for this (the demos' visual regression should be enough). Feel free to remove them. |
It can't find any demo that covers this specific case. Perhaps it's best to keep them? |
Signed-off-by: Jan Potoms <[email protected]>
Signed-off-by: Jan Potoms <[email protected]>
Noticed that the spacing was off when different components are used for
Card
actions. See the spacing between second and third action here.Also fixes #29819