Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] Move useAutocomplete to the Unstyled package #27485

Merged
merged 3 commits into from
Aug 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/pages/components/autocomplete/CustomizedHook.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable @typescript-eslint/no-use-before-define */
import * as React from 'react';
import PropTypes from 'prop-types';
import useAutocomplete from '@material-ui/core/useAutocomplete';
import { useAutocomplete } from '@material-ui/unstyled/AutocompleteUnstyled';
import CheckIcon from '@material-ui/icons/Check';
import CloseIcon from '@material-ui/icons/Close';
import { styled } from '@material-ui/core/styles';
Expand Down
5 changes: 3 additions & 2 deletions docs/src/pages/components/autocomplete/CustomizedHook.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
/* eslint-disable @typescript-eslint/no-use-before-define */
import * as React from 'react';
import useAutocomplete, {
import {
useAutocomplete,
AutocompleteGetTagProps,
} from '@material-ui/core/useAutocomplete';
} from '@material-ui/unstyled/AutocompleteUnstyled';
import CheckIcon from '@material-ui/icons/Check';
import CloseIcon from '@material-ui/icons/Close';
import { styled } from '@material-ui/core/styles';
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/autocomplete/UseAutocomplete.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-disable @typescript-eslint/no-use-before-define */
import * as React from 'react';
import useAutocomplete from '@material-ui/core/useAutocomplete';
import { useAutocomplete } from '@material-ui/unstyled/AutocompleteUnstyled';
import { styled } from '@material-ui/core/styles';

const Label = styled('label')({
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/components/autocomplete/UseAutocomplete.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-disable @typescript-eslint/no-use-before-define */
import * as React from 'react';
import useAutocomplete from '@material-ui/core/useAutocomplete';
import { useAutocomplete } from '@material-ui/unstyled/AutocompleteUnstyled';
import { styled } from '@material-ui/core/styles';

const Label = styled('label')({
Expand Down
2 changes: 1 addition & 1 deletion packages/material-ui-lab/src/useAutocomplete/index.d.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export { default } from '@material-ui/core/useAutocomplete';
export { useAutocomplete as default } from '@material-ui/unstyled';
2 changes: 1 addition & 1 deletion packages/material-ui-lab/src/useAutocomplete/index.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export { default, createFilterOptions } from '@material-ui/core/useAutocomplete';
export { useAutocomplete as default, createFilterOptions } from '@material-ui/unstyled';
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export { default as useAutocomplete } from './useAutocomplete';
export * from './useAutocomplete';
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { default as useAutocomplete, createFilterOptions } from './useAutocomplete';
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
/* eslint-disable no-constant-condition */
import * as React from 'react';
import { setRef, useEventCallback, useControlled, unstable_useId as useId } from '../utils';
import {
unstable_setRef as setRef,
unstable_useEventCallback as useEventCallback,
unstable_useControlled as useControlled,
unstable_useId as useId,
} from '@material-ui/utils';

// https://stackoverflow.com/questions/990904/remove-accents-diacritics-in-a-string-in-javascript
// Give up on IE11 support for this feature
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import useAutocomplete, { FilterOptionsState } from '@material-ui/core/useAutocomplete';
import { useAutocomplete, FilterOptionsState } from '@material-ui/unstyled/AutocompleteUnstyled';
import { expectType } from '@material-ui/types';

interface Person {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as React from 'react';
import { expect } from 'chai';
import { createClientRender, screen, ErrorBoundary } from 'test/utils';
import useAutocomplete, { createFilterOptions } from '@material-ui/core/useAutocomplete';
import { useAutocomplete, createFilterOptions } from '@material-ui/unstyled/AutocompleteUnstyled';

describe('useAutocomplete', () => {
const render = createClientRender();
Expand Down
2 changes: 2 additions & 0 deletions packages/material-ui-unstyled/src/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
export * from './AutocompleteUnstyled';

export { default as BackdropUnstyled } from './BackdropUnstyled';
export * from './BackdropUnstyled';

Expand Down
2 changes: 2 additions & 0 deletions packages/material-ui-unstyled/src/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
export * from './AutocompleteUnstyled';

export { default as BackdropUnstyled } from './BackdropUnstyled';
export * from './BackdropUnstyled';

Expand Down
7 changes: 4 additions & 3 deletions packages/material-ui/src/Autocomplete/Autocomplete.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,16 @@ import { ChipProps, ChipTypeMap } from '@material-ui/core/Chip';
import { PopperProps } from '@material-ui/core/Popper';
import { SxProps } from '@material-ui/system';
import { OverridableStringUnion } from '@material-ui/types';
import { AutocompleteClasses } from './autocompleteClasses';
import useAutocomplete, {
import {
useAutocomplete,
AutocompleteChangeDetails,
AutocompleteChangeReason,
AutocompleteCloseReason,
AutocompleteInputChangeReason,
createFilterOptions,
UseAutocompleteProps,
} from '../useAutocomplete';
} from '@material-ui/unstyled';
import { AutocompleteClasses } from './autocompleteClasses';

export {
AutocompleteChangeDetails,
Expand Down
7 changes: 5 additions & 2 deletions packages/material-ui/src/Autocomplete/Autocomplete.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@ import * as React from 'react';
import PropTypes from 'prop-types';
import clsx from 'clsx';
import { chainPropTypes, integerPropType } from '@material-ui/utils';
import { unstable_composeClasses as composeClasses } from '@material-ui/unstyled';
import {
unstable_composeClasses as composeClasses,
useAutocomplete,
createFilterOptions,
} from '@material-ui/unstyled';
import { alpha } from '@material-ui/system';
import Popper from '../Popper';
import ListSubheader from '../ListSubheader';
Expand All @@ -11,7 +15,6 @@ import IconButton from '../IconButton';
import Chip from '../Chip';
import ClearIcon from '../internal/svg-icons/Close';
import ArrowDropDownIcon from '../internal/svg-icons/ArrowDropDown';
import useAutocomplete, { createFilterOptions } from '../useAutocomplete';
import useThemeProps from '../styles/useThemeProps';
import styled from '../styles/styled';
import autocompleteClasses, { getAutocompleteUtilityClass } from './autocompleteClasses';
Expand Down
4 changes: 0 additions & 4 deletions packages/material-ui/src/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ export * from './AppBar';

export { default as Autocomplete } from './Autocomplete';
export * from './Autocomplete';

export { default as Avatar } from './Avatar';
export * from './Avatar';

Expand Down Expand Up @@ -462,9 +461,6 @@ export * from './useScrollTrigger';
export { default as Zoom } from './Zoom';
export * from './Zoom';

export { default as useAutocomplete } from './useAutocomplete';
export * from './useAutocomplete';

export { default as GlobalStyles } from './GlobalStyles';
export * from './GlobalStyles';

Expand Down
3 changes: 0 additions & 3 deletions packages/material-ui/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -398,9 +398,6 @@ export * from './useScrollTrigger';
export { default as Zoom } from './Zoom';
export * from './Zoom';

// createFilterOptions is exported from Autocomplete
export { default as useAutocomplete } from './useAutocomplete';

export { default as GlobalStyles } from './GlobalStyles';
export * from './GlobalStyles';

Expand Down
2 changes: 0 additions & 2 deletions packages/material-ui/src/useAutocomplete/index.d.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/material-ui/src/useAutocomplete/index.js

This file was deleted.

4 changes: 2 additions & 2 deletions test/bundling/scripts/fixtureTemplateValues.js
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,8 @@ import { Typography as Typography_core } from '@material-ui/core';
import Typography_core__pathImport from '@material-ui/core/Typography';
import { Unstable_TrapFocus as Unstable_TrapFocus_core } from '@material-ui/core';
import Unstable_TrapFocus_core__pathImport from '@material-ui/core/Unstable_TrapFocus';
import { useAutocomplete as useAutocomplete_core } from '@material-ui/core';
import useAutocomplete_core__pathImport from '@material-ui/core/useAutocomplete';
import { useAutocomplete as useAutocomplete_core } from '@material-ui/unstyled';
import useAutocomplete_core__pathImport from '@material-ui/unstyled/AutocompleteUnstyled';
import { useMediaQuery as useMediaQuery_core } from '@material-ui/core';
import useMediaQuery_core__pathImport from '@material-ui/core/useMediaQuery';
import { usePagination as usePagination_core } from '@material-ui/core';
Expand Down