Skip to content

Commit

Permalink
remove notistack library
Browse files Browse the repository at this point in the history
  • Loading branch information
ZeeshanTamboli committed Jun 24, 2024
1 parent 2e05775 commit a22a359
Show file tree
Hide file tree
Showing 8 changed files with 1 addition and 110 deletions.
31 changes: 0 additions & 31 deletions docs/data/material/components/snackbars/IntegrationNotistack.js

This file was deleted.

31 changes: 0 additions & 31 deletions docs/data/material/components/snackbars/IntegrationNotistack.tsx

This file was deleted.

16 changes: 0 additions & 16 deletions docs/data/material/components/snackbars/snackbars.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,22 +86,6 @@ This demo shows how to display multiple Snackbars without stacking them by using

{{"demo": "ConsecutiveSnackbars.js"}}

## Third-party integrations

### notistack

![stars](https://img.shields.io/github/stars/iamhosseindhv/notistack.svg?style=social&label=Star)
![npm downloads](https://img.shields.io/npm/dm/notistack.svg)

With an imperative API, [notistack](https://github.com/iamhosseindhv/notistack) lets you vertically stack multiple Snackbars without having to handle their open and close states.
Even though this is discouraged in the Material Design guidelines, it is still a common pattern.

{{"demo": "IntegrationNotistack.js", "defaultCodeOpen": false}}

:::warning
Note that notistack prevents Snackbars from being [closed by pressing <kbd class="key">Escape</kbd>](#accessibility).
:::

## Accessibility

The user should be able to dismiss Snackbars by pressing <kbd class="key">Escape</kbd>. If there are multiple instances appearing at the same time and you want <kbd class="key">Escape</kbd> to dismiss only the oldest one that's currently open, call `event.preventDefault` in the `onClose` prop.
Expand Down
1 change: 0 additions & 1 deletion docs/next.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ export default withDocsInfra({
(ctx, callback) => {
const { request } = ctx;
const hasDependencyOnRepoPackages = [
'notistack',
'@mui/x-data-grid',
'@mui/x-data-grid-pro',
'@mui/x-date-pickers',
Expand Down
1 change: 0 additions & 1 deletion docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
"markdown-to-jsx": "^7.4.7",
"material-ui-popup-state": "^5.1.2",
"next": "^13.5.1",
"notistack": "3.0.1",
"nprogress": "^0.2.0",
"postcss": "^8.4.38",
"postcss-import": "^16.1.0",
Expand Down
28 changes: 0 additions & 28 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ module.exports = function setKarmaConfig(config) {
{
test: /\.(js|mjs|jsx)$/,
include:
/node_modules(\/|\\)(notistack|@mui(\/|\\)x-data-grid|@mui(\/|\\)x-data-grid-pro|@mui(\/|\\)x-license-pro|@mui(\/|\\)x-data-grid-generator|@mui(\/|\\)x-date-pickers-pro|@mui(\/|\\)x-date-pickers|@mui(\/|\\)x-tree-view)/,
/node_modules(\/|\\)(@mui(\/|\\)x-data-grid|@mui(\/|\\)x-data-grid-pro|@mui(\/|\\)x-license-pro|@mui(\/|\\)x-data-grid-generator|@mui(\/|\\)x-date-pickers-pro|@mui(\/|\\)x-date-pickers|@mui(\/|\\)x-tree-view)/,
use: {
loader: 'babel-loader',
options: {
Expand Down
1 change: 0 additions & 1 deletion test/regressions/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ const blacklist = [
'docs-components-snackbars/CustomizedSnackbars.png', // Redundant
'docs-components-snackbars/DirectionSnackbar.png', // Needs interaction
'docs-components-snackbars/FabIntegrationSnackbar.png', // Needs interaction
'docs-components-snackbars/IntegrationNotistack.png', // Needs interaction
'docs-components-snackbars/PositionedSnackbar.png', // Needs interaction
'docs-components-snackbars/SimpleSnackbar.png', // Needs interaction
'docs-components-snackbars/TransitionsSnackbar.png', // Needs interaction
Expand Down

0 comments on commit a22a359

Please sign in to comment.