Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new logo #750

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Use the new logo #750

wants to merge 9 commits into from

Conversation

vladmoroz
Copy link
Contributor

@vladmoroz vladmoroz commented Oct 21, 2024

  • New logo and favicons
  • Tweaked homepage

@mui-bot
Copy link

mui-bot commented Oct 21, 2024

Netlify deploy preview

https://deploy-preview-750--base-ui.netlify.app/

Generated by 🚫 dangerJS against 6a88502

@vladmoroz vladmoroz added the docs Improvements or additions to the documentation label Oct 21, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 21, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 21, 2024
@vladmoroz vladmoroz marked this pull request as ready for review October 21, 2024 22:08
@vladmoroz vladmoroz changed the title Use new logo Use the new logo Oct 22, 2024
Comment on lines +8 to +28
:root {
--color-content: #fff;
--color-background: oklch(98% 0.25% 264);
--color-foreground: oklch(21% 2% 264);
--color-selection: oklch(80% 0.2 264 / 60%);
--color-gray: oklch(12.7% 6% 264 / 67%);
--color-link: oklch(47% 50% 264);
--color-border: oklch(20% 12% 264 / 25%);
--color-gridline: oklch(91.6% 1% 264);

@media (prefers-color-scheme: dark) {
--color-content: #000;
--color-background: #000;
--color-foreground: oklch(90% 2% 264);
--color-selection: oklch(50% 0.2 264 / 80%);
--color-gray: oklch(90% 6% 264 / 70%);
--color-link: oklch(69% 50% 264);
--color-border: oklch(90% 12% 264 / 35%);
--color-gridline: oklch(24% 1% 264);
}
}
Copy link
Contributor Author

@vladmoroz vladmoroz Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functional colours are provisional, it's likely I'll end up doing a normal Radix-style palette once there is a bit more interactive UI to work with

@@ -38,6 +38,9 @@ module.exports = {
},
],
'@typescript-eslint/no-redeclare': 'off',

// We LOVE non-breaking spaces here
'no-irregular-whitespace': 'off',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't setting { skipJSXText: true, skipStrings: true } be enough?

{description}
</h1>
<p className="text-color-gray mb-4 text-pretty 2xl:text-lg">
From the creators of Radix, Floating UI, and MUI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
From the creators of Radix, Floating UI, and MUI.
From the creators of Radix, Floating UI, and Material UI.

import { Metadata } from 'next';
import { GoogleAnalytics } from 'docs/src/components/GoogleAnalytics';
import * as React from 'react';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a convention to import React first.

@@ -0,0 +1,19 @@
@layer components {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what's wrong with CSS modules after all? Are we going to have plain CSS, CSS modules, and Tailwind at the same time, or do you want to get rid of modules completely?

@michaldudak
Copy link
Member

Side note: could you prefix your PR titles with the main tag ([docs] in this case)? It's a convention we use across our repos (and it makes it easier to write the changelog).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants