[AlertDialog, Dialog, Popover] Configure initial focus #732
+513
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
enhancement
Netlify deploy preview |
michaldudak
force-pushed
the
dialog-initial-focus
branch
2 times, most recently
from
3cf1d49
to
76026c0
Compare
michaldudak
force-pushed
the
dialog-initial-focus
branch
from
76026c0
to
8ba8514
Compare
github-actions
bot
added
the
PR: out-of-date
atomiks
reviewed
Oct 17, 2024
Co-authored-by: atomiks <[email protected]> Signed-off-by: Michał Dudak <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
michaldudak
changed the title
michaldudak
added
the
component: alert dialog
vladmoroz
reviewed
Oct 18, 2024
There was a problem hiding this comment.
- An existing bug, but just noticed that in
/experiments/dialog/, in the second dialog (CSS animation example) the initial focus isn't placed into the popup at all - Is
""meant to be among pointer types? - Since pointer type includes
"keyboard", should we name this argument and type differently?
michaldudak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
initialFocusprop to control what element is focused after the Dialog, AlertDialog, or Popover is open.By default it focuses the first element, unless the component was opened by touch interaction - in that case the popup itself is focused.
Part of #714