[Menu] Fix custom anchor positioning #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy preview |
atomiks
reviewed
Sep 16, 2024
| // Therefore, if the anchor is a ref, we need to update the position reference in useEffect. | ||
| const resolvedAnchor = typeof anchor === 'function' ? anchor() : anchor; | ||
| if (isRef(resolvedAnchor) && resolvedAnchor.current !== registeredPositionReference.current) { | ||
| refs.setPositionReference(resolvedAnchor.current); |
There was a problem hiding this comment.
Is flushSync necessary now, if there will be a flicker?
There was a problem hiding this comment.
I haven't noticed it flickering. With the menu initially open, even with 20x CPU slowdown, the popup appears only near the anchor.
atomiks
reviewed
Sep 17, 2024
| const anchorRef = useLatestRef(anchor); | ||
| const rerender = useForcedRerendering(); | ||
|
|
||
| const registeredPositionReference = React.useRef<Element | VirtualElement | null>(null); |
There was a problem hiding this comment.
Suggested change
| const registeredPositionReference = React.useRef<Element | VirtualElement | null>(null); | |
| const registeredPositionReferenceRef = React.useRef<Element | VirtualElement | null>(null); |
atomiks
reviewed
Sep 17, 2024
Comment on lines
207
to
208
| const rerender = useForcedRerendering(); | ||
|
|
There was a problem hiding this comment.
This doesn't seem to be actually used? It's just in the dep array
There was a problem hiding this comment.
Right, it's a leftover from a previous attempt.
michaldudak
added
component: menu
atomiks
approved these changes
Sep 17, 2024
colmtuite
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
anchorprop works only in development mode, when React runs the effect twice. This is because we read the anchor ref in useLayoutEffect, when it hasn't been set yet. Additionally, passing the Element directly didn't work as well.This PR adds an extra effect after the first render, that checks if the ref value changed after useLayoutEffect was called. If so, it calls
setPositionReferenceagain with the ref value.