[Menu] RadioItem component #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
component: menu
Netlify deploy preview |
github-actions
bot
added
PR: out-of-date
michaldudak
force-pushed
the
menu-radioitem
branch
from
bf51bb3
to
cc1caee
Compare
atomiks
reviewed
Sep 18, 2024
atomiks
reviewed
Sep 18, 2024
atomiks
reviewed
Sep 18, 2024
Comment on lines
+22
to
+28
| const setValue = React.useCallback( | ||
| (newValue: any, event: Event) => { | ||
| setValueUnwrapped(newValue); | ||
| onValueChange?.(newValue, event); | ||
| }, | ||
| [onValueChange, setValueUnwrapped], | ||
| ); |
|
@michaldudak I was surprised that the Menu doesn't close when you select a radio item using Enter. Radix closes the menu whether you select a radio/checkbox item via click, space, or Enter. RA closes on Enter only. Do you think we should keep the Menu open always? Or close when you select a radio item using Enter? |
|
Yeah, it should close after Enter is pressed. I'll fix it. |
|
I made the change. I won't update the CheckboxItem, as it's the same code. Once RadioItem gets merged, the CheckboxItem will work automatically. |
atomiks
approved these changes
Sep 19, 2024
colmtuite
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created the MenuItemRadioItem and related components.
Closes #53