Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider] Fix Home / End regression #526

Merged
merged 7 commits into from
Aug 21, 2024
Merged

[Slider] Fix Home / End regression #526

merged 7 commits into from
Aug 21, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Aug 4, 2024 •
edited by oliviertassinari
Loading

Closes #484

@mui-bot
Copy link

mui-bot commented Aug 4, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-526--base-ui.netlify.app/

Generated by 🚫 dangerJS against 6f9205f

@zannager zannager added component: slider This is the name of the generic UI component, not the React module! package: base-ui labels Aug 5, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 9, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 18, 2024
michaldudak
michaldudak approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@michaldudak michaldudak merged commit 919d9ca into mui:master Aug 21, 2024
18 checks passed
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work regression A bug, but worse labels Aug 21, 2024
@oliviertassinari
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

@atomiks atomiks Awaiting requested review from atomiks atomiks is a code owner

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module! regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Slider] Home / End regression
5 participants
@sai6855 @mui-bot @oliviertassinari @michaldudak @zannager