[CheckboxGroup] Implement components and hooks #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomiks
added
the
component: checkbox
Netlify deploy preview |
github-actions
bot
added
the
PR: out-of-date
atomiks
force-pushed
the
feat/CheckboxGroup
branch
from
14e28ea
to
64d67a9
Compare
github-actions
bot
removed
the
PR: out-of-date
Init conformance tests Fix label context test test Update
atomiks
force-pushed
the
feat/CheckboxGroup
branch
from
af887e3
to
de6e4f0
Compare
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: atomiks <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
michaldudak
reviewed
Aug 21, 2024
docs/data/base/components/checkbox-group/UnstyledCheckboxGroupIntroduction/css/index.js
Outdated
Show resolved
Hide resolved
docs/data/base/components/checkbox-group/UnstyledCheckboxGroupIntroduction/css/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
When I select some items (such as Red and Green) and click on All Colors repeatedly, the selection goes from all to none to Red and Green again. This is quite unexpected (I can't recall seeing such behavior elsewhere). Usually, the parent checkbox toggles between all and none and the partially selected state is lost.
I would make it configurable if you want to keep this behavior.
There was a problem hiding this comment.
This is what the ARIA demo does, but yeah I can make it configurable
There was a problem hiding this comment.
Added preserveChildStates prop
packages/mui-base/src/CheckboxGroup/Root/CheckboxGroupRootContext.ts
Outdated
Show resolved
Hide resolved
packages/mui-base/src/CheckboxGroup/Parent/useCheckboxGroupParent.types.ts
Outdated
Show resolved
Hide resolved
colmtuite
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #213