[test] Extract common popup tests #1358
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
michaldudak
force-pushed
the
common-popup-tests
branch
from
c4d413b to
ae787c7
Compare
github-actions
bot
added
PR: out-of-date
michaldudak
force-pushed
the
common-popup-tests
branch
from
dc0f139 to
9ff3306
Compare
atomiks
reviewed
Feb 7, 2025
| role: 'presentation', | ||
| hidden: !mounted, |
There was a problem hiding this comment.
So it's consistent with other roles - they are placed on popups, not positioners. Is it an issue?
There was a problem hiding this comment.
For some screen readers, the positioner wrapper needs to have role="presentation" to not interfere with the child popup role from what I've gathered. It makes it 'inert'/ignored by them. The popup is what should have the ARIA role, but never role=presentation
There was a problem hiding this comment.
👍 All right, I'll remove the role check from the common tests and revert this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help ensure all our popup-based components work in a similar way, I added a popup test suite that's shared across all these components. I have included just the basic tests so far. It can be extended to test modality going forward.
Additional changes:
Created async versions of
rerenderandsetPropsfunctions returned fromrenderin tests. They now behave similarly torenderas they flush the microtask queue before returning.