Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated deprecated MediaStream.stop() in Audio recorder example #560

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

moosthuizen42
Copy link

Replaced microphone.stop() with microphone.getTracks().forEach( t => t.stop());

MediaStream.stop() is deprecated according to https://developer.mozilla.org/en-US/docs/Web/API/Media_Streams_API.

I experienced the same problem described in: 
https://stackoverflow.com/questions/34966809/stop-kill-webrtc-media-stream.

According to https://developer.mozilla.org/en-US/docs/Web/API/Media_Streams_API, MediaStream.stop() is deprecated.

This commit changes .stop() to .getTracks().forEach( t => t.stop());
@thijstriemstra
Copy link
Contributor

ping @muaz-khan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants