Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default prefixes #71

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

nbittich
Copy link
Contributor

No description provided.

@nvdk
Copy link
Member

nvdk commented Aug 25, 2023

I quite like the idea of supporting prefixes, but I think the implementation needs to be different. Rather than adding the prefixes in the sparql queries I think we need to expand the prefixes on reading the config. This might be done in https://github.com/mu-semtech/mu-search/blob/master/lib/mu_search/property_definition.rb#L10 .

This is required because we will not get prefixed predicates from delta's for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants