Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Improvement/better errors #9

Draft
wants to merge 23 commits into
base: feature/consistency-with-credo
Choose a base branch
from

Conversation

ajuvercr
Copy link

@ajuvercr ajuvercr commented Sep 17, 2021

Many things.

Mostly rewrite the recursive descent parser, but I'm not happy with it yet.

This parser is faster most of the times and returns some kind of errors.

Also adds a profiler, set env PROFILE=true, this creates a file /tmp/prof.json with profile things. To use this file, fix the json by adding ]} then insert the file in chrome://tracing/ in chromium and enjoy.

@ajuvercr
Copy link
Author

TODO:

  • integrate into mu-auth currently only the implementation is present (with tests) but the actual mu-auth doesn't use it
  • actually make errors better
  • according to the sparql docs, the grammar is parsable with a LL(1) parser, maybe look at that? Should bring better performance and better errors

@erikap erikap marked this pull request as draft October 3, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant