-
Notifications
You must be signed in to change notification settings - Fork 19
basic midi example #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Interesting. How would I use it? |
The example shows how to send midi with raw serial packages.. but, I was thinking I'd probably try this: https://docs.rs/embedded-midi/0.1.0/embedded_midi/index.html I could update the example to use that, but I wasn't sure if we'd want to add additional deps. |
or.. maybe you're wondering about the hardware? both the field and the patch have MIDI i/o |
A bit of both. I've not used MIDI. As far as the extra crate goes that's what [dev-dependencies] exists for. |
}; | ||
|
||
/// Get a configured serial MIDI device | ||
pub fn midi( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation is very specific with hard coded pins and serial settings. Unless the h/w or protocol restricts it these should be configurable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah.. this is specific to the serial midi that these 2 devices support, but i could make it more general and then make a specific call if we end up with a Field
and or Patch
class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, midi does have a specific serial setting that it needs, but this could be configurable to different pin for non Field
or Patch
devices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as it's clear that the specific pins are for field/patch h/w I'm fine with either a specific or general implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good. i'll make some changes to either make that more clear or make it more general or both
No description provided.