Rely on default files list for hex package
#98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial goal for this change was to incorporate the CHANGELOG into the hex package so that it would be available in the diff tool on hex.pm or the command line (i.e. `mix hex.package diff thousand_island 1.1.0..1.2.0`). Per discussion in mtrudel/bandit#265 we'll accomplish the above by removing the `files` configuration and relying on the default list of files provided by hex (see the linked issue for details). This change will also have the effect of removing test files from future releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial goal for this change was to incorporate the CHANGELOG into the hex package so that it would be available in the diff tool on hex.pm or the command line (i.e.
mix hex.package diff thousand_island 1.1.0..1.2.0).Per discussion in mtrudel/bandit#265 we'll accomplish the above by removing the
filesconfiguration and relying on the default list of files provided by hex (see the linked issue for details).This change will also have the effect of removing test files from future releases.