Fix config options merging

[moogle19]

Currently the user_options could overwrite the @hardcoded_options but not the default_options (gen_tcp seems to take the last option if multiple values for 1 key are defined).

This fixes the problem by allowing the user_options to overwrite the default_options and applying the @hardcoded_options last.

[mtrudel]

Looks great! I'd always thought that the first value wins, as with keyword lists.

I added some tests to cover this, since it's surprising behaviour.

Thanks for the PR!

[mtrudel]

Pushed as 1.3.4

[danschultzer]

This breaks options for gen_tcp: https://www.erlang.org/doc/man/gen_tcp#listen-2

AFAIK keyword list is an Elixir only thing. In Erlang the options (at least for gen_tcp) is a list of tuples or atoms. I'm setting the ipfamily explicitly so the list will be akin to:[log_level: :warning, :inet6]

[mtrudel]

Aw shoot you're right. We had fixed that previously but I don't think it's under test, hence the regression

I'm out for the evening but I can fix this up tomorrow. Sorry for the trouble

[mtrudel]

Fix is up at #112, but there's a failing test for ssl that suggests maybe it's a bit more complicated than gen_tcp. Take a look!

[travelmassive]

I think I'm affected by this issue. Just grabbed the latest bandit (1.2.3) which nudged thousand_island to 1.3.4

My web server was failing with:

2024-02-24T00:18:48.622223+00:00 web.1  |     ** (EXIT) shutdown: failed to start child: {AppWeb.Endpoint, :http}
2024-02-24T00:18:48.622312+00:00 web.1  |         ** (EXIT) shutdown: failed to start child: :listener
2024-02-24T00:18:48.622356+00:00 web.1  |             ** (EXIT) an exception was raised:
2024-02-24T00:18:48.622406+00:00 web.1  |                 ** (ArgumentError) expected a keyword list as the second argument, got: [:inet6]
2024-02-24T00:18:48.622598+00:00 web.1  |                     (thousand_island 1.3.4) lib/thousand_island/transports/tcp.ex:60: ThousandIsland.Transports.TCP.listen/2
2024-02-24T00:18:48.622643+00:00 web.1  |                     (thousand_island 1.3.4) lib/thousand_island/listener.ex:29: ThousandIsland.Listener.init/1
2024-02-24T00:18:48.622689+00:00 web.1  |                     (stdlib 3.17.2) gen_server.erl:423: :gen_server.init_it/2
2024-02-24T00:18:48.622735+00:00 web.1  |                     (stdlib 3.17.2) gen_server.erl:390: :gen_server.init_it/6
2024-02-24T00:18:48.622556+00:00 web.1  |                     (elixir 1.13.4) lib/keyword.ex:922: Keyword.merge/2
 web.1  |                     (stdlib 3.17.2) proc_lib.erl:226: :proc_lib.init_p_do_apply/3

My thousand_island_options config in my prod.exs is:

thousand_island_options: [
      transport_options: [
        :inet6
      ]
    ]

Reverting thousand_island to 1.3.3 fixed it.

Hope this is helpful -- Ian.

[mtrudel]

Yep. Fix is up in the linked PR. I ran out of time to get it over the line today but should get it out as 1.3.5 tomorrow.

[mtrudel]

Fix published as 1.3.5!

[travelmassive]

Thanks, working again :)