Don't abort when there's not enough space in the left or right page margin #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalaspuffar
approved these changes
Jan 19, 2022
PaulRambags
approved these changes
Jan 25, 2022
kalaspuffar
requested changes
Feb 14, 2022
There was a problem hiding this comment.
> Task :checkstyleMain
[ant:checkstyle] [ERROR] /home/danielp/github/dotify.library/src/org/daisy/dotify/formatter/impl/page/PageImpl.java:30: Wrong order for 'java.util.Optional' import. [ImportOrder]
[ant:checkstyle] [ERROR] /home/danielp/github/dotify.library/src/org/daisy/dotify/formatter/impl/page/PageImpl.java:247: Line is longer than 120 characters (found 125). [LineLength]
…argin (to render a marker-indicator) when the "allowsTextOverflowTrimming" option is set. Instead show a warning. This addresses Github issue mtmse#23 about "handling errors gracefully instead of aborting".
bertfrees
force-pushed
the
allow-text-overflow
branch
from
7363348 to
7919db2
Compare
|
Fixed it and rebase onto main. |
kalaspuffar
approved these changes
Feb 14, 2022
|
PR approved, running regression tests. |
|
Regression tests passed, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kalaspuffar @PaulRambags I've addressed an issue that was mentioned in #23, namely that when there is not enough space in left or right page margin to render content, there should be an option to handle it gracefully. It turned out there was already an option called "allowsTextOverflowTrimming" which I've used. What do you think?