-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to handle errors gracefully instead of aborting #23
Labels
Comments
We agreed that it is a good thing in general to try to do a best effort when something can not be rendered according to the OBFL contract, but also provide the option to not deviate from the contract (abort if needed). However how to best handle it is to be decided case by case.
|
Note that there is already a |
bertfrees
added a commit
to bertfrees/dotify.library
that referenced
this issue
Jan 11, 2022
…argin (to render a marker-indicator) when the "allowsTextOverflowTrimming" option is set. Instead show a warning. This addresses Github issue mtmse#23 about "handling errors gracefully instead of aborting".
bertfrees
added a commit
to bertfrees/dotify.library
that referenced
this issue
Feb 14, 2022
…argin (to render a marker-indicator) when the "allowsTextOverflowTrimming" option is set. Instead show a warning. This addresses Github issue mtmse#23 about "handling errors gracefully instead of aborting".
bertfrees
added a commit
to bertfrees/dotify.library
that referenced
this issue
May 31, 2022
…ded space Related to mtmse#23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It is a wish of some users to be able to get an output from a (valid) OBFL document regardless of whether there were issues during the conversion. If possible, a valid PEF should be returned, even if it's not the "correct" result, and another return value should indicate whether the PEF is "correct" or not.
It's important to make a distinction between unexpected errors (due to bugs in Dotify), validation errors and other errors. The new option would only have an effect on the last category.
Examples:
(A lot more examples can be thought of. We should probably go through the whole code and categorize all the exceptions that are thrown.)
Some errors will be harder to handle gracefully than other. We don't need to handle them all but we should do a best effort.
The text was updated successfully, but these errors were encountered: