Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 7825: Trash Jarogniew Mercs using corp basic action #7834

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

heyshiloh
Copy link
Contributor

This PR seeks to close #7825

Screenshot 2024-10-21 at 12 42 27 PM

Description of changes:

  • adjust implementation of :untrashable-while-resources flag in corp basic action

Methodology described in this comment

Fixing this also resolves an unreported but related issue where the current logic creates a situation where a click is spent attempting to trash mercs instead of bouncing off of the choices logic

Testing - here is the log from the test game with the new logic

test1 has created the game.
test2 joined the game.
! MirrorMorph: Endless Iteration - Does not work with terminal Operations
test2 keeps their hand.
test1 keeps their hand.
test2 started their turn 1 with 5  and 5 cards in HQ.
test2 makes their mandatory start of turn draw.
test2 spends  to install a card in Server 1 (new remote).
test2 spends  to use Corp Basic Action Card to gain 1 .
test2 spends  to use Corp Basic Action Card to gain 1 .
test2 is ending their turn 1 with 7  and 5 cards in HQ.
test1 started their turn 1 with 5  and 2 cards in their Grip.
test1 spends  and pays 0  to install Jarogniew Mercs.
test1 spends  and pays 4  to install Earthrise Hotel.
test1 spends  to use Runner Basic Action Card to gain 1 .
test1 spends  to use Runner Basic Action Card to gain 1 .
test1 is ending their turn 1 with 3  and 0 cards in their Grip.
test2 started their turn 2 with 7  and 5 cards in HQ.
test2 makes their mandatory start of turn draw.
// here i attempt to trash mercs first but it does nothing, so i select earthrise first and then trash mercs
test2 spends  and pays 2  to use Corp Basic Action Card to trash Earthrise Hotel.
test2 spends  and pays 2  to use Corp Basic Action Card to trash Jarogniew Mercs.

@NoahTheDuke NoahTheDuke merged commit 0e62a29 into mtgred:master Oct 29, 2024
3 checks passed
@heyshiloh heyshiloh deleted the nr-7825-trash-jarogniew-mercs branch October 29, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apparently we can't trash Jarogniew mercs anymore
2 participants