Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maw fix #6986

Merged
merged 2 commits into from
Aug 4, 2023
Merged

maw fix #6986

merged 2 commits into from
Aug 4, 2023

Conversation

NBKelly
Copy link
Collaborator

@NBKelly NBKelly commented Aug 3, 2023

We don't have any events for the maw thing, so it's just checking that at the end of the access, the number of cards not trashed/scored = 1, and that the card is not in the trash.
This is obviously not logically complete.
We're now checking it's not in the score area either, which is still not perfect, but should fix all the issues.

If it doesn't, then a more complete (but much less terse) fix is to actually raise an event instead of just incrementing a register.

Actually, that's on my todo list. I'll do it in the next month or so.

Closes #6985
Closes #6946
Closes #6157

@NoahTheDuke
Copy link
Collaborator

I don't think firing an event works because this needs to be checked after accessing the card which is when :post-access-card fires. How do you envision it would work?

@NBKelly
Copy link
Collaborator Author

NBKelly commented Aug 3, 2023

Fair.

That's a problem for me to figure out in a month or two. This patch should fix all the issues with maw currently.

@NoahTheDuke NoahTheDuke merged commit e2ed145 into mtgred:master Aug 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants