Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add power and toughness to card model. #21

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add power and toughness to card model. #21

wants to merge 6 commits into from

Conversation

pak21
Copy link
Contributor

@pak21 pak21 commented Dec 23, 2019

Fetch the power and toughness of every card. Notes:

  1. Everything which doesn't have a printed power and toughness does have these set to zero in the MTGA data so that's replicated here.
  2. I haven't attempted to update the hard-coded old set data in source/mtga/set_data to include the power and toughness - not sure I think it's worth it as they're already out of date, and getting more out of data with every release.

@pak21
Copy link
Contributor Author

pak21 commented Jun 27, 2020

Gentle prod on this :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pak21