Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This won't translate #25

Open
SwissalpS opened this issue Dec 26, 2021 · 4 comments
Open

This won't translate #25

SwissalpS opened this issue Dec 26, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@SwissalpS
Copy link

S("This %s belongs to %s. You can't remove or edit it."):format(

@Panquesito7 Panquesito7 added the bug Something isn't working label Dec 26, 2021
@Panquesito7
Copy link
Member

We need to change this to:

		minetest.chat_send_player(player_name,
			S("This @1 belongs to @2. You can't remove or edit it.",
				description,
				tostring(owner_name)
			)
		)

We can set this as a good first-issue and let beginners resolve it, or solve it ourselves by making a PR. 🙂

@SwissalpS
Copy link
Author

Yes, thanks.
That solves half the problem. The other part of the 'problem' is that many other languages have genders.
description itself will be able to contain those, for languages like German, and the Latin based ones I am thinking of.
Not sure how Japanese and Hindi would cope.
My suggestion: Have two strings, one for travelnets and one for elevators and only insert owner_name dynamically.

@SwissalpS SwissalpS reopened this Dec 26, 2021
@OgelGames
Copy link

Maybe that should be put in a separate issue?

@SwissalpS
Copy link
Author

or solve as I suggested in comments to #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants