Add granite bricks #229
Merged
Add granite bricks #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Click for detailed source code test coverage reportTest coverage report for Technic CNC 79.48% in 8/8 files:Test coverage report for technic 9.61% in 10/103 files:Raw test runner output for geeks:CNC: Technic: |
|
Should |
From the lua api docs: This should not really matter IMO and the field removed entirely, the bricks are artificially crafted/placed and should not end up somewhere in mapgen anyway |
Yeah, maybe I was thinking bit too much ahead probably as I was actually thinking about mapgen buildings (for mods discussed around pandorabox ideas repo). |
I would say yes, that would be better, but that can be left for a different PR, as other nodes should have that changed too. |
OgelGames
approved these changes
Oct 27, 2021
|
Tested, seems nice and good. Texture could be updated to make edges nicer, seems to be just default stone brick texture over granite node. I bet someone will notice that in game too, probably stone brick can be used just fine but with some better filter to make it similar to other dark bricks instead of following edges of light bricks. |
|
I am ok with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds granite bricks from
sfence(original PR here: minetest-mods/technic#593)@sfence i took the liberty and copied your code and textures, if thats alright with you (i like the addition 😄)