Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix placing certain signs #29

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Fix placing certain signs #29

merged 2 commits into from
Jun 3, 2024

Conversation

tenplus1
Copy link
Contributor

This fixes #1 by removing node extensions before placing, just incase player got a hold of certain sign nodes they shouldnt have.

This fixes mt-mods#1 by removing node extensions before placing, just incase player got a hold of certain sign nodes they shouldnt have.
@OgelGames
Copy link
Contributor

Alternatively, you could remove the after_place_node function from the other sign nodes here, after the table gets copied:

signs_lib/api.lua

Line 1088 in 3d5ba32

local othermounts_def = table.copy(def)

othermounts_def.after_place_node = nil

@tenplus1
Copy link
Contributor Author

tenplus1 commented Apr 23, 2024

@OgelGames - Tried that, gives an error, and using an empty function has sign placement issues.

api.lua Outdated Show resolved Hide resolved
fix typo
@SwissalpS
Copy link
Contributor

Maybe this change to MT helps in future versions
minetest/minetest@408faa1

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Jun 3, 2024
@wsor4035 wsor4035 merged commit 4309b35 into mt-mods:master Jun 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: "default:sign_steel_yard_yard" is not a registered node
5 participants