Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash passwords #8

Closed
wants to merge 6 commits into from
Closed

Hash passwords #8

wants to merge 6 commits into from

Conversation

SwissalpS
Copy link
Contributor

If there are concerns about data bloat, we can probably get away with truncating the hashes or using sha1 instead of sha256.

I didn't go through the trouble to add a setting to choose the algorithm (or none), but if that is requested, I'll implement it. IMO that's just complicating things.

There is also an amendment to a previous commit snuck in this one: variable admin priv wasn't being presented to users correctly.

@louisroyer feel free to implement this in your/upstream fork.

@SwissalpS SwissalpS added the enhancement New feature or request label Sep 11, 2024
@louisroyer
Copy link

@louisroyer feel free to implement this in your/upstream fork.

Thank you for the ping, but I am not the author of upstream, nor do I maintain any fork of this mod. I have a mod that optionally depends of playerfactions, but it is not interacting with factions passwords and is hopefully compatible with your PR.

@wsor4035
Copy link
Contributor

this means the mod would only support 5.9 ..... minetest/minetest@762fca5

@SwissalpS
Copy link
Contributor Author

this means the mod would only support 5.9 ..... minetest/minetest@762fca5

I take it that's a no-go for you?
Would sha1 be available on enough earlier servers? (any hash algo is already a bit better than none or minetest.serialize)

@SwissalpS
Copy link
Contributor Author

We would need to at minimum add a tag/branch to the current state for anyone that wants to continue using cleartext anyway.

@S-S-X
Copy link
Member

S-S-X commented Sep 15, 2024

Bumping up minimum version in my opinion is best thing to do here but as it apparently was 5.0 and change in compatibility is significant it could be good to at least tag last stable point with better compatibility (master branch atow) or create and advertise a release package.

@SwissalpS
Copy link
Contributor Author

SwissalpS commented Sep 15, 2024

Might be good to cherry-pick some of the locale edits from #10 before making an EOL package release.

Edit: and while at it add some languages

@wsor4035
Copy link
Contributor

support of the last two major releases of minetest is generally accepted minimum, however not hard set opposed 🤷

@SwissalpS SwissalpS marked this pull request as draft September 17, 2024 23:25
@SwissalpS
Copy link
Contributor Author

closing in favour of #11 and #12

@SwissalpS SwissalpS closed this Sep 18, 2024
@SwissalpS SwissalpS mentioned this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants