Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add safe version of os.date #2

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Add safe version of os.date #2

merged 1 commit into from
Jul 19, 2023

Conversation

OgelGames
Copy link
Contributor

Adds os.date with full functionality, but without the ability to crash :)

@OgelGames OgelGames added the enhancement New feature or request label Jul 17, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5578050268

  • 1 of 13 (7.69%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 23.913%
Changes Missing Coverage Covered Lines Changed/Added Lines %
controller.lua 1 13 7.69%
Totals Coverage Status
Change from base Build 5315446794: -0.3%
Covered Lines: 154
Relevant Lines: 644
💛 - Coveralls

wsor4035
wsor4035 approved these changes Jul 17, 2023
View reviewed changes
Copy link

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok, might be worth another pair of eyes just in case

@OgelGames OgelGames merged commit a7a6eb9 into master Jul 19, 2023
@OgelGames
Copy link
Contributor Author

Ugh, wrong merge type...

OgelGames added a commit that referenced this pull request Jul 19, 2023
@OgelGames
Add safe version of os.date (#2)
cf28c3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsor4035 wsor4035 wsor4035 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OgelGames @coveralls @wsor4035