Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Timezone offset setting + setting type number #145

Merged
merged 3 commits into from
Apr 20, 2024
Merged

Add Timezone offset setting + setting type number #145

merged 3 commits into from
Apr 20, 2024

Conversation

Athozus
Copy link
Member

@Athozus Athozus commented Apr 14, 2024

This PR has 2 commits :

  • Add support for setting type number. Almost like string.
  • Add timezone_offset setting, and add it to the message date.

Rebase should be the best option.

Quite simple, the review should be quick 😉

Resolve #125

screenshot_20240414_154706
screenshot_20240414_154711
screenshot_20240414_154722

@Athozus Athozus added the Enhancement New feature or request label Apr 14, 2024
@Athozus Athozus added this to the 1.4.0 milestone Apr 14, 2024
y5nw
y5nw reviewed Apr 14, 2024
View reviewed changes
Copy link
Contributor

@y5nw y5nw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from what I added to the comment it seems like the TZ offset is not reset when you hit the "Reset" button.

util/settings.lua Outdated Show resolved Hide resolved
ui/settings.lua Outdated Show resolved Hide resolved
Athozus and others added 2 commits April 20, 2024 17:35
@Athozus
Add support for number type settings
e8e48b2 
Fix reset issue
@Athozus @y5nw
Add timezone offset setting
4632185 
Clarify timezone offset tooltip

Co-authored-by: y5nw <[email protected]>
@Athozus Athozus merged commit ed6f36a into master Apr 20, 2024
22 checks passed
@Athozus Athozus deleted the timezone-setting branch April 22, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y5nw y5nw y5nw left review comments

Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Time zone of the date information
2 participants
@Athozus @y5nw