Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace physics hell with hopefully better entity hell #81

Merged
merged 7 commits into from
Oct 31, 2024

Conversation

wsor4035
Copy link
Collaborator

@wsor4035 wsor4035 commented Oct 27, 2024

image

something something #78 - see title


basically physics overrides suck. trying to make multiple mods play nicely with them really sucks. so in an effort to bypass the whole flaming dumpster, attaching the player to an entity that does nothing to prevent them for moving at all, regardless of what physics modifiers nightmare fuel is occuring


  • armchair
  • sofa
  • longsofa
  • deckchair
  • deckchair striped blue
  • kitchen chair
  • kitchen chair padded
  • office chair basic
  • office chair upscale
  • simple bench

@wsor4035 wsor4035 requested a review from Niklp09 October 27, 2024 01:56
@OgelGames
Copy link
Contributor

cheapie did the same thing for the digistuff game controller a while back and it's worked much better since the change: mt-mods/digistuff@b16d25c

@BuckarooBanzay
Copy link
Member

(i updated the pandorabox server to this PR)

Looks like this works most of the time, but it needs a few clicks sometimes:

screenshot_20241027_075346
screenshot_20241027_075331
screenshot_20241027_075318

The animation is always gone afterwards though 👍

@wsor4035
Copy link
Collaborator Author

image

there are other chairs to fix..... some of which crash. probably because they arent all hardware colored

@wsor4035
Copy link
Collaborator Author

wsor4035 commented Oct 27, 2024

they all work now. this pr is rotation handling is kinda hacky and probably could be improved at some point. but more so caring that they all work

Copy link
Member

@Niklp09 Niklp09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine. Switching to the sitting animation doesn't works quite unreliable but I don't see why. Probably an engine issue since other mods have similar issues.

homedecor_seating/init.lua Outdated Show resolved Hide resolved
@wsor4035 wsor4035 linked an issue Oct 31, 2024 that may be closed by this pull request
@wsor4035 wsor4035 merged commit 4089810 into master Oct 31, 2024
2 checks passed
@BuckarooBanzay
Copy link
Member

BuckarooBanzay commented Oct 31, 2024

thanks for the work @wsor4035

@MCLV-pandorabox
Copy link

Sorry, I don't get this github stuff very well yet. so many places to put comments, no idea what is the right place.
I appreciate the efforts that went into this change, hate to be a buzz kill, but I see that issue #78 is now closed and there are still some problems with it.
I've put the details in the original issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sitting animation
5 participants