feat(query): add in and notIn filters to NumberQuery
#150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
reviewed
Oct 27, 2021
kettanaito
reviewed
Oct 27, 2021
kettanaito
requested changes
Oct 27, 2021
There was a problem hiding this comment.
Hey, @ruisaraiva19! These changes are top-notch, thank you for your work on this.
I had only one comment regarding the number[] type. Would you mind looking into that? Should be rather trivial to fix.
kettanaito
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Thank you for your work on this feature, @ruisaraiva19! Welcome to contributors! 🎉
Let me know if there are any other tasks you may be interested in tackling, we could use your expertise.
|
@kettanaito maybe I can take a shot at #56. |
|
@ruisaraiva19, that's a great choice! Let me know if you have any questions, we can discuss the task in #56. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub
inandnotInfilters for NumberQuery #151Changes
inandnotInnumber comparators (NumberQuery).notIn,between,notBetween) to be aGraphQLList(TYPE). Corrects the related tests.