-
Notifications
You must be signed in to change notification settings - Fork 5
enhancement: show specified n, slope and depth/WSE in cross-section display #5
base: master
Are you sure you want to change the base?
Conversation
Thanks for your input. I'm glad you have found the plugin useful. Unfortunately, I am unable to continue development at this time. Feel free to fork and fix the issues. |
…the user can tweak it to get exactly the flow they want)
Hi,
I presume this is still the case.
I have now adapted it to work in QGIS 3.x as well as 2.x, and am hoping to fix one more issue before making a release (I'm now working in my master branch if anyone is wanting to look at the changes). Thanks. |
Hi,
Yes, please release a new version of the same plugin. It doesn’t make sense to rename it and confuse the users. I am still unable to work on this, and I appreciate your help in maintaining!
Thanks,
Mitch
From: AlisterH [mailto:[email protected]]
Sent: Tuesday, January 7, 2020 7:00 AM
To: msweier/QGISflowEstimator <[email protected]>
Cc: Weier, Mitchell S CIV USARMY CEMVP (US) <[email protected]>; Comment <[email protected]>
Subject: [Non-DoD Source] Re: [msweier/QGISflowEstimator] enhancement: show specified n, slope and depth/WSE in cross-section display (#5)
Hi,
Unfortunately, I am unable to continue development at this time.
I presume this is still the case.
Feel free to fork and fix the issues.
I have now adapted it to work in QGIS 3.x as well as 2.x, and am hoping to fix one more issue before making a release (I'm now working in my master branch if anyone is wanting to look at the changes).
Would you be OK with me releasing it as a new version of the same plugin, rather than renaming it to create a new plugin? I don't see any benefit in releasing it as a new plugin, and I'm sure any current users would appreciate being notified of the new version.
Thanks.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<Blockedhttps://github.com/msweier/QGISflowEstimator/pull/5?email_source=notifications&email_token=ACH62SS6OEH4SDIVEUEMQGDQ4R4ENA5CNFSM4GO2MXS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIIY4VI#issuecomment-571575893>, or unsubscribe<Blockedhttps://github.com/notifications/unsubscribe-auth/ACH62SR4C4LCFVJLOXXX4PTQ4R4ENANCNFSM4GO2MXSQ>.
|
Done, please check. |
The cross-section display shows almost all the information required for many purposes. This pull request adds the specified depth/WSE, roughness and channel slope, which essentially allows it to be presented standalone, or just with the rating curve.
When defining a trapezoidal channel it should really display the specified bottom width and side slopes as well, but that makes the layout trickier - ideally the dimensions could be shown on the actual cross-section though, with just the results shown to the right. Alternatively, if you consider that the dimensions don't really need to included, you might just want to add the roughness and channel slope, and leave out the depth/WSE.