6272 move status change to footer #6276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle size differenceComparing this PR to
|
lache-melvin
commented
Jan 24, 2025
| @@ -46,7 +46,7 @@ export const SplitButton = <T,>({ | |||
| <ButtonGroup color={color} variant="outlined" aria-label={ariaLabel}> | |||
| <ButtonWithIcon | |||
| color={color} | |||
| disabled={isDisabled} | |||
| disabled={isDisabled || selectedOption.isDisabled} | |||
There was a problem hiding this comment.
Hopefully we are okay with the change?
lache-melvin
commented
Jan 24, 2025
| @@ -81,11 +81,15 @@ const useSaveWithStatus = ( | |||
| }; | |||
| }; | |||
|
|
|||
| const useSaveWithStatusChangeModal = ( | |||
| const useSaveWithStatusChange = ( | |||
There was a problem hiding this comment.
just renaming as I'm now using both in and outside of the modal
lache-melvin
commented
Jan 24, 2025
| @@ -133,7 +142,7 @@ export const Footer: FC<FooterProps> = ({ | |||
| gap={2} | |||
| > | |||
| <Typography sx={{ fontSize: 18, fontWeight: 700 }}> | |||
| Document Edit History | |||
| {t('label.document-edit-history')} | |||
There was a problem hiding this comment.
side quest - missed translation from ages ago!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6272
👩🏻💻 What does this PR do?
Make status change/delete workflows of encounters match those of other features.
Removes status change and delete from toolbar.
Adds delete button to side panel, and status change to footer:
Pre-requisite to hooking into status change logic within vax card.
💌 Any notes for the reviewer?
🧪 Testing
Mark as Visitedby default📃 Documentation
1.
2.