Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6177 create patient from prescription window #6269

Merged
merged 9 commits into from
Jan 30, 2025

Conversation

GeronimoJohn
Copy link
Contributor

Fixes #6177

πŸ‘©πŸ»β€πŸ’» What does this PR do?

Added functionality to create a patient through the prescription window. A "Create Patient" button has been added to the prescriptions section, which opens a modal for creating a new patient. After filling out the form in the modal, the user is redirected to the Patient form, as a patient code is required for creation. Once the patient is created, the user is redirected back to the prescriptions page.

Screen.Recording.2025-01-24.at.9.30.08.AM.mov

πŸ’Œ Any notes for the reviewer?

πŸ§ͺ Testing

  • Open prescription window
  • Click on create patient button
  • Fill out the patient form and click next
  • Click create new button
  • Click generate button
  • Click on create button
  • Accept the changes
  • Will be redirected to prescriptions page

πŸ“ƒ Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

@github-actions github-actions bot added this to the v2.6.0 milestone Jan 23, 2025
@github-actions github-actions bot added Team Piwakawaka James, Carl, John, Zachariah feature: dispensing labels Jan 23, 2025
Copy link

github-actions bot commented Jan 23, 2025

Bundle size difference

Comparing this PR to main

Old size New size Diff
5.25 MB 5.26 MB 5.25 KB (0.10%)

@CarlosNZ CarlosNZ self-assigned this Jan 27, 2025
Copy link
Contributor

@CarlosNZ CarlosNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @GeronimoJohn .

Just a couple of suggestions.

There's one other thing we've missed though: If you click "New Patient", and then search and find an existing patient from the subsequent modal, when you click the patient (rather than starting a new one), you get re-directed back to a new prescription, but with the following error:

Screenshot 2025-01-28 at 11 27 00β€―AM

@CarlosNZ
Copy link
Contributor

Also, see this comment/issue: #6292 (comment)

I think this is probably a good way to go (not for this issue, but sometime soon). What do you think @jmbrunskill @mark-prins ?

Copy link
Contributor

@CarlosNZ CarlosNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks @GeronimoJohn

Just that one little suggestion if you want to fix before you merge.

Cheers πŸ‘

@GeronimoJohn GeronimoJohn merged commit cae05f6 into develop Jan 30, 2025
4 checks passed
@GeronimoJohn GeronimoJohn deleted the 6177-create-patient-from-prescription-window branch January 30, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: dispensing Team Piwakawaka James, Carl, John, Zachariah
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dispensing: Create Patient from Prescription Window
2 participants