-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6177 create patient from prescription window #6269
6177 create patient from prescription window #6269
Conversation
Bundle size differenceComparing this PR to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @GeronimoJohn .
Just a couple of suggestions.
There's one other thing we've missed though: If you click "New Patient", and then search and find an existing patient from the subsequent modal, when you click the patient (rather than starting a new one), you get re-directed back to a new prescription, but with the following error:
client/packages/system/src/Patient/Components/PatientSearchModal/PatientSearchModal.tsx
Outdated
Show resolved
Hide resolved
client/packages/system/src/Patient/Components/PatientSearchModal/PatientSearchModal.tsx
Outdated
Show resolved
Hide resolved
client/packages/system/src/Patient/CreatePatientModal/CreatePatientModal.tsx
Show resolved
Hide resolved
Also, see this comment/issue: #6292 (comment) I think this is probably a good way to go (not for this issue, but sometime soon). What do you think @jmbrunskill @mark-prins ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks @GeronimoJohn
Just that one little suggestion if you want to fix before you merge.
Cheers π
Fixes #6177
π©π»βπ» What does this PR do?
Added functionality to create a patient through the prescription window. A "Create Patient" button has been added to the prescriptions section, which opens a modal for creating a new patient. After filling out the form in the modal, the user is redirected to the Patient form, as a patient code is required for creation. Once the patient is created, the user is redirected back to the prescriptions page.
Screen.Recording.2025-01-24.at.9.30.08.AM.mov
π Any notes for the reviewer?
π§ͺ Testing
π Documentation
1.
2.