5122 fix user can create shipment from requisition without permission set

[noel-yeldos]

Fixes #5122

👩🏻‍💻 What does this PR do?

Disable the creation of shipments from requisitions for users who do not have the create invoice permission set. Thanks @lache-melvin for pointing me in the right direction!

Screen.Recording.2025-01-22.at.11.57.47.AM.mov

💌 Any notes for the reviewer?

This change makes it so that users who do not have the "create invoice" permission cannot create invoices from the requisition. However, there is a "create customer invoice from requisition" permission in OG that hasn't been mapped yet to OMS. Therefore, if you leave "create customer invoice from requisition" unchecked, you can still create shipments from requisitions if you have "create invoice" permission. @mark-prins worth doing the mapping?

🧪 Testing

• Create User1 and give it permission to View Requisitions and Edit requisitions. Do not give 'Create invoice' permission
• Go to a Remote site>Distribution> Requisitions and choose a Requisition to supply
• Click on the button 'Supply requested'
• Click on button 'Create Shipment'
• Observe message that lets the user know they do not have permission to create shipment

📃 Documentation

• Part of an epic: documentation will be completed for the feature as a whole
• No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
• These areas should be updated or checked:
  1.
  2.

[github-actions]

Bundle size difference

Comparing this PR to main

Old size	New size	Diff
5.21 MB	5.21 MB	490 B (0.01%)

[lache-melvin]

LGTM - but before I approve, keen to hear from @mark-prins whether we want the granularity of mapping the create invoices from requisitions permission through instead

[mark-prins]

Actually - OG does not check the create invoice permission when creating invoices from a requisition!
That's checking for both the Transfer goods between stores and Create invoices from requisitions permissions to be set.

I would prefer to bring through the Create invoices from requisitions permission and use that. Only that though as this gives the greatest flexibility - it means that a user can be denied the permission to create invoices manually while still being about to fulfil customer requisitions. It does require setting two permissions for those users who do both, but that's ok

[noel-yeldos]

@mark-prins @lache-melvin What should be done here? Should I do the mapping in this PR or create an enhancement issue?

[lache-melvin]

Update in this PR please 🙏

[lache-melvin]

Epic thanks for changes!