6144 add check for exceeding max orders

[fergie-nz]

Fixes #6144

👩🏻‍💻 What does this PR do?

Adds back end check to ensure we don't create program requisitions when the maximum number for that period has been reached.

Also adds front end error handling when attempting to create more than the specified number of

💌 Any notes for the reviewer?

I think we should spend time adding back end tests to creating program requisitions. Right now there is quite complicated logic with no tests validating.

Any fixes such as this one are time consuming to deal with. It is also currently unclear if there are other gaps in the logic without tests.

🧪 Testing

The way to test this using in app behaviour is to attempt to create duplicate requisitions which combined would exceed the maximum number together.
This requires 2 browsers:

• Create a program active on a site with an order type of maximum orders of 1
• Log in to OMS on two separate browsers
• Open the UI to create a requisition of this order type for a given period
• Create 2 requisitions at the same time from the 2 different browsers
• See error prompt

📃 Documentation

• No documentation required: no user facing changes or a bug fix which isn't a change in behaviour

[github-actions]

Bundle size difference

Comparing this PR to main

Old size	New size	Diff
5.21 MB	5.21 MB	1.63 KB (0.03%)

[roxy-dao]

Thanks for the changes Ferg. I've given it a quick whirl. Don't wanna comment on code yet until this is fixed..

As you can see my max orders for this order type is 2~ but I have managed to make 4 orders for this order type both through having two instances opened + directly calling endpoint 😭

[fergie-nz]

Thanks for the changes Ferg. I've given it a quick whirl. Don't wanna comment on code yet until this is fixed..

As you can see my max orders for this order type is 2~ but I have managed to make 4 orders for this order type both through having two instances opened + directly calling endpoint 😭

Oh no! Thanks Roxy,

I saw a gap in the logic where you would be able to create one more when existing = max, but not 4.

I'm getting this error response when I try to create more. Are you still able to recreate making many more than max?